Skip to content

feat(agent): Decouple Browser Session Tracking from backgroundTools #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(agent): Decouple Browser Session Tracking from backgroundTools #297

wants to merge 1 commit into from

Conversation

bhouston
Copy link
Member

Decouple Browser Session Tracking from backgroundTools

This PR implements the changes requested in issue #291 to decouple browser session tracking from the backgroundTools implementation.

Changes Made

  1. Created a dedicated BrowserTracker class in packages/agent/src/tools/browser/browserTracker.ts that is responsible for tracking browser sessions
  2. Implemented a new listBrowsers tool in packages/agent/src/tools/browser/listBrowsers.ts that provides similar functionality to listBackgroundTools but focused only on browser sessions
  3. Updated browseStart.ts and browseMessage.ts to use the new browserTracker instead of backgroundTools
  4. Modified backgroundTools.ts to remove browser-related code
  5. Ensured all tests pass

Benefits

  • Reduced coupling between different tool types
  • More focused and maintainable code
  • Easier to extend or modify browser-specific functionality
  • Clearer separation of concerns

Testing

All tests pass, confirming that the changes maintain backward compatibility while providing the desired decoupling.

Fixes #291

@bhouston
fix: fix build errors in browser tracker implementation
5dedfe9 
- Fixed type errors in browser tracker implementation

- Updated tests to remove browser-related code from backgroundTools tests

- Added default agent name for browser tracker tools
@bhouston bhouston mentioned this pull request Mar 14, 2025
Closed
6 tasks
@bhouston
Copy link
Member Author

This has been merged via a different PR.

@bhouston bhouston closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple Browser Session Tracking from backgroundTools
1 participant
@bhouston